summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAshutosh Dixit <ashutosh.dixit@intel.com>2022-07-01 20:05:37 -0700
committerAshutosh Dixit <ashutosh.dixit@intel.com>2022-07-06 14:12:01 -0700
commit903100e3b0791b535de03cb0bac0506e99d3a3c4 (patch)
treeebd7021c3c560178ff8d0415a16655f939e6eb2e
parentff483cfd7ea5c7dd03ba59bc68447571200bbb2e (diff)
lib/amdgpu/amd_command_submission: Fix -Wuse-after-free
../lib/amdgpu/amd_command_submission.c: In function ‘amdgpu_command_submission_write_linear_helper’: ../lib/amdgpu/amd_command_submission.c:201:13: warning: pointer ‘ring_context’ used after ‘free’ [-Wuse-after-free] 201 | r = amdgpu_cs_ctx_free(ring_context->context_handle); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../lib/amdgpu/amd_command_submission.c:199:9: note: call to ‘free’ here 199 | free(ring_context); | ^~~~~~~~~~~~~~~~~~ Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
-rw-r--r--lib/amdgpu/amd_command_submission.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/amdgpu/amd_command_submission.c b/lib/amdgpu/amd_command_submission.c
index 4dc4df95..16939653 100644
--- a/lib/amdgpu/amd_command_submission.c
+++ b/lib/amdgpu/amd_command_submission.c
@@ -196,10 +196,10 @@ void amdgpu_command_submission_write_linear_helper(amdgpu_device_handle device,
}
/* clean resources */
free(ring_context->pm4);
- free(ring_context);
/* end of test */
r = amdgpu_cs_ctx_free(ring_context->context_handle);
igt_assert_eq(r, 0);
+ free(ring_context);
}