diff options
| author | Matthew Auld <matthew.auld@intel.com> | 2022-06-27 17:10:02 +0100 |
|---|---|---|
| committer | Matthew Auld <matthew.auld@intel.com> | 2022-06-28 15:42:49 +0100 |
| commit | d6d1ac4b3d936f850aa63373d7ae05ebf7254f81 (patch) | |
| tree | 2a12b5c6772180ced697a7c95c76153215c96739 | |
| parent | 35840762d3ee78e146a5a02aa6fe14dd7b4179a8 (diff) | |
tests/i915/gem_eio: fix uaf
../tests/i915/gem_eio.c:277:20: warning: pointer ‘ctx’ used after ‘free’ [-Wuse-after-free]
277 | igt_assert(igt_sysfs_printf(ctx->debugfs, "i915_drop_caches",
../lib/igt_core.h:667:20: note: in definition of macro ‘igt_assert’
667 | do { if (!(expr)) \
| ^~~~
../tests/i915/gem_eio.c:274:9: note: call to ‘free’ here
274 | free(ctx);
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
| -rw-r--r-- | tests/i915/gem_eio.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/i915/gem_eio.c b/tests/i915/gem_eio.c index 913a21f9..6cbae6eb 100644 --- a/tests/i915/gem_eio.c +++ b/tests/i915/gem_eio.c @@ -270,11 +270,11 @@ static void hang_handler(union sigval arg) igt_nsec_elapsed(&ctx->delay) / 1000.0); igt_assert_eq(timer_delete(ctx->timer), 0); - free(ctx); /* flush any excess work before we start timing our reset */ igt_assert(igt_sysfs_printf(ctx->debugfs, "i915_drop_caches", "%d", DROP_RCU)); + free(ctx); igt_nsec_elapsed(ts); igt_assert(igt_sysfs_printf(dir, "i915_wedged", "%llu", -1ull)); |