| Age | Commit message (Collapse) | Author |
|---|
|
There's a bunch of reasons why I think we should formalize and enforce
our review rules for igt patches:
- We have a lot of new engineers joining and review helps enormously
with mentoring and learning. But right now only patches from
contributors without commit rights are consistently subjected to
review, which makes this imbalanced and removes senior contributors
from the review pool.
- We have a much bigger team and we need to make sure we're aligned on
where igt as a tool and testsuite needs to head towards. Getting
that alignment happens through reviewing each other's submission.
Pushing a contentious patch and then dealing with a heated irc
discussion is much less effective.
- Finally igt becomes ever more important for our testing, making sure
the code quality is high is important. Review helps with that.
v2: Improve wording a bit (Imre).
Acked-by: Daniel Stone <daniels@collabora.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Acked-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Acked-by: Petri Latvala <petri.latvala@intel.com>
Acked-by: Imre Deak <imre.deak@intel.com>
Acked-by: Robert Foss <robert.foss@collabora.com>
Acked-by: Ben Widawsky <ben@bwidawsk.net>
Acked-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Acked-by: Mika Kuoppala <mika.kuoppala@intel.com>
Acked-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Acked-by: Eric Anholt <eric@anholt.net>
Acked-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Acked-by: Lyude <lyude@redhat.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
|
|
CONTRIBUTING requests that people do this, but it's a lot easier if we
just set it up by default for them.
v2: Update CONTRIBUTING about this happening (suggested by Petri).
Signed-off-by: Eric Anholt <eric@anholt.net>
Acked-by: Petri Latvala <petri.latvala@intel.com> (v1)
|
|
Duplication just means it gets out of sync.
Also update they keyword list in the Makefile, not everything was listed.
And add a new "invalid" keyword.
While at it update NEWS.
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
|
|
Acked-by: Daniel Vetter <daniel.vetter@intel.com>
Signed-off-by: Thomas Wood <thomas.wood@intel.com>
|
|
i-g-t has become a fairly big project with lots of people involved, so
lets document the basics and formalize the current process a bit.
Also use this opportunity to announce Thomas Wood as igt maintainer
once more.
v2: Recommend --subject-prefix="PATCH i-g-t" as suggested by Damien.
v3: Clean out contributing-related information from README.
Cc: Thomas Wood <thomas.wood@intel.com>
Cc: Damien Lespiau <damien.lespiau@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
|
