From 8770e24fe4008404da769c16b7edac6142225ad7 Mon Sep 17 00:00:00 2001 From: Harish Chegondi Date: Wed, 3 Apr 2019 18:26:30 -0700 Subject: i915/pm_backlight: Do not turn off DPMS before system suspend MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit backlight fade with suspend test turns off dpms which turns off the edp backlight. Then it does a system suspend and resume. After resume, the edp backlight would still be off, but the test sets the brightness value and reads it back. Since the edp backlight is off, the brightness values written and read are different causing the test to fail. Do not turn off the DPMS before suspend so that after system resume, the edp backlight would be on and setting the brightness value would be successful. v2: Remove "DPMS off" before system suspend instead of adding "DPMS on" after system resume. Cc: Jyoti Yadav Cc: Chris Wilson Cc: Daniel Vetter Cc: Clinton Taylor Signed-off-by: Harish Chegondi References: https://bugs.freedesktop.org/show_bug.cgi?id=107820 Fixes: 377752242995 ("Brightness test with DPMS and System suspend.") Reviewed-by: Daniel Vetter Reviewed-by: José Roberto de Souza --- tests/i915/i915_pm_backlight.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/tests/i915/i915_pm_backlight.c b/tests/i915/i915_pm_backlight.c index 054300f6..4c1bff5b 100644 --- a/tests/i915/i915_pm_backlight.c +++ b/tests/i915/i915_pm_backlight.c @@ -175,13 +175,6 @@ test_fade_with_dpms(struct context *context, igt_output_t *output) static void test_fade_with_suspend(struct context *context, igt_output_t *output) { - igt_require(igt_setup_runtime_pm()); - - kmstest_set_connector_dpms(output->display->drm_fd, - output->config.connector, - DRM_MODE_DPMS_OFF); - igt_require(igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED)); - igt_system_suspend_autoresume(SUSPEND_STATE_MEM, SUSPEND_TEST_NONE); test_fade(context); -- cgit v1.2.3