From e3647eb9e9200b4eac974eaa2fed5abf8e621b76 Mon Sep 17 00:00:00 2001 From: Ville Syrjälä Date: Wed, 17 Apr 2019 20:59:32 +0300 Subject: tests/i915/gem_render_copy: Don't leak bos between subtests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Unref the bos after one subtest is done. The next subtest will allocate its own bos. v2: Add scratch_buf_fini() and reverse the onion (Chris) Signed-off-by: Ville Syrjälä Reviewed-by: Chris Wilson --- tests/i915/gem_render_copy.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/tests/i915/gem_render_copy.c b/tests/i915/gem_render_copy.c index 8d62a0f4..b5d1f45f 100644 --- a/tests/i915/gem_render_copy.c +++ b/tests/i915/gem_render_copy.c @@ -459,6 +459,11 @@ static void scratch_buf_init(data_t *data, struct igt_buf *buf, igt_assert(igt_buf_height(buf) == height); } +static void scratch_buf_fini(struct igt_buf *buf) +{ + drm_intel_bo_unreference(buf->bo); +} + static void scratch_buf_check(data_t *data, struct igt_buf *buf, @@ -662,6 +667,13 @@ static void test(data_t *data, uint32_t tiling, uint64_t ccs_modifier) if (ccs_modifier) scratch_buf_aux_check(data, &ccs); + + scratch_buf_fini(&ref); + if (ccs_modifier) + scratch_buf_fini(&ccs); + scratch_buf_fini(&dst); + for (int i = 0; i < num_src; i++) + scratch_buf_fini(&src[i].buf); } static int opt_handler(int opt, int opt_index, void *data) -- cgit v1.2.3