From 07be8fec156ba8405f2aafa3a37fe29d06893f05 Mon Sep 17 00:00:00 2001 From: Matt Roper Date: Thu, 5 Mar 2015 15:01:00 -0800 Subject: igt.cocci: Replace igt_assert() with igt_assert_CMP() where possible The integer comparison macros give us better error output by including the actual values that failed the comparison. Signed-off-by: Matt Roper Signed-off-by: Daniel Vetter --- lib/igt.cocci | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) (limited to 'lib/igt.cocci') diff --git a/lib/igt.cocci b/lib/igt.cocci index 41a8beb3..7dc398d0 100644 --- a/lib/igt.cocci +++ b/lib/igt.cocci @@ -141,3 +141,35 @@ a = drm_open_any(); - return ...; - } ) + +// Use comparison macros instead of raw igt_assert when possible +@@ +typedef uint32_t; +uint32_t E1, E2; +int E3, E4; +@@ +( +- igt_assert(E1 == E2); ++ igt_assert_eq_u32(E1, E2); +| +- igt_assert(E1 != E2); ++ igt_assert_neq_u32(E1, E2); +| +- igt_assert(E1 <= E2); ++ igt_assert_lte_u32(E1, E2); +| +- igt_assert(E1 < E2); ++ igt_assert_lt_u32(E1, E2); +| +- igt_assert(E3 == E4); ++ igt_assert_eq(E3, E4); +| +- igt_assert(E3 != E4); ++ igt_assert_neq(E3, E4); +| +- igt_assert(E3 <= E4); ++ igt_assert_lte(E3, E4); +| +- igt_assert(E3 < E4); ++ igt_assert_lt(E3, E4); +) -- cgit v1.2.3