From 47f6b1305cc3752f318a555b932e194e1500c1d8 Mon Sep 17 00:00:00 2001 From: Thomas Wood Date: Wed, 25 Mar 2015 16:42:57 +0000 Subject: igt.cocci: check the return values of various functions Add rules to fix unused-result warnings when compiling with _FORTIFY_SOURCE defined and apply them to the library and tests. Acked-by: Daniel Vetter Signed-off-by: Thomas Wood --- lib/igt.cocci | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) (limited to 'lib/igt.cocci') diff --git a/lib/igt.cocci b/lib/igt.cocci index 7dc398d0..156f0cf2 100644 --- a/lib/igt.cocci +++ b/lib/igt.cocci @@ -173,3 +173,31 @@ int E3, E4; - igt_assert(E3 < E4); + igt_assert_lt(E3, E4); ) + +// avoid unused-result warnings when compiling with _FORTIFY_SOURCE defined +@@ +identifier func =~ "^(read|write)$"; +expression list[2] E; +expression size; +@@ +-func(E, size); ++igt_assert_eq(func(E, size), size); + +@@ +expression ptr, size, nmemb, stream; +@@ +-fread(ptr, size, nmemb, stream); ++igt_assert_eq(fread(ptr, size, nmemb, stream), nmemb); + +@@ +expression list E; +@@ +-fgets(E); ++igt_assert_neq(fgets(E), NULL); + +@@ +identifier func =~ "^v?asprintf$"; +expression list E; +@@ +-func(E); ++igt_assert_neq(func(E), -1); -- cgit v1.2.3