From fc85a9b16b73a51116d17468361e67a1f4e55592 Mon Sep 17 00:00:00 2001 From: Paul Kocialkowski Date: Thu, 10 Jan 2019 15:16:59 +0100 Subject: lib/igt_chamelium: Fixup resources liberation in comparison helpers This fixes a bunch of occurrences of memory not being properly liberated after its use in helpers revolving around frame/CRC comparison. Signed-off-by: Paul Kocialkowski Reviewed-by: Lyude Paul Reviewed-by: Maxime Ripard --- lib/igt_chamelium.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) (limited to 'lib/igt_chamelium.c') diff --git a/lib/igt_chamelium.c b/lib/igt_chamelium.c index 32b859ea..0b6ac37a 100644 --- a/lib/igt_chamelium.c +++ b/lib/igt_chamelium.c @@ -1060,9 +1060,9 @@ void chamelium_assert_crc_eq_or_dump(struct chamelium *chamelium, free(reference_suffix); free(capture_suffix); - chamelium_destroy_frame_dump(frame); - + cairo_surface_destroy(reference); cairo_surface_destroy(capture); + chamelium_destroy_frame_dump(frame); } igt_assert(eq); @@ -1120,11 +1120,14 @@ void chamelium_assert_analog_frame_match_or_dump(struct chamelium *chamelium, free(reference_suffix); free(capture_suffix); + free(reference_crc); + free(capture_crc); } - cairo_surface_destroy(capture); - igt_assert(match); + + cairo_surface_destroy(reference); + cairo_surface_destroy(capture); } @@ -1323,6 +1326,8 @@ igt_crc_t *chamelium_calculate_fb_crc(int fd, struct igt_fb *fb) chamelium_do_calculate_fb_crc(fb_surface, ret); + cairo_surface_destroy(fb_surface); + return ret; } -- cgit v1.2.3