From 937df2ef91e6cd524a9bfc54e973de465d587d54 Mon Sep 17 00:00:00 2001 From: Daniel Vetter Date: Wed, 13 Feb 2019 11:35:49 +0100 Subject: lib: Make sure we leak no child processes There's a lot more ways to leak children than igt_fork, some even handrolled. So check for that. Also have a nice littel testcase for that too. v2: Don't hang if there's a leaked child process (Chris). Has the added benefit that my library unit test also gets faster! v3: Rebase. Cc: Chris Wilson Reviewed-by: Chris Wilson Signed-off-by: Daniel Vetter --- lib/igt_core.c | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'lib/igt_core.c') diff --git a/lib/igt_core.c b/lib/igt_core.c index 607b34cd..425b96ff 100644 --- a/lib/igt_core.c +++ b/lib/igt_core.c @@ -1492,6 +1492,8 @@ void __igt_fail_assert(const char *domain, const char *file, const int line, */ void igt_exit(void) { + int tmp; + igt_exit_called = true; if (igt_key_file) @@ -1527,6 +1529,8 @@ void igt_exit(void) kill(test_children[c], SIGKILL); assert(!num_test_children); + assert(waitpid(-1, &tmp, WNOHANG) == -1 && errno == ECHILD); + if (!test_with_subtests) { struct timespec now; const char *result; -- cgit v1.2.3