From c07af1f4713b4d014de8fd0d401f9e3ed639f6d6 Mon Sep 17 00:00:00 2001 From: Ville Syrjälä Date: Wed, 6 Jun 2018 16:28:31 +0300 Subject: lib/igt_matrix: Unroll and inline igt_matrix_transform() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Using the current igt_matrix for NV12 conversion ends up being about 4x as slow as the current non-igt_matrix based code. Unrolling and inlining igt_matrix_transform() improves that factor to ~1.5x. Cc: Maarten Lankhorst Signed-off-by: Ville Syrjälä Reviewed-by: Chris Wilson --- lib/igt_matrix.c | 25 ------------------------- 1 file changed, 25 deletions(-) (limited to 'lib/igt_matrix.c') diff --git a/lib/igt_matrix.c b/lib/igt_matrix.c index 3fa6c96c..35a9c321 100644 --- a/lib/igt_matrix.c +++ b/lib/igt_matrix.c @@ -24,8 +24,6 @@ #include "igt_core.h" #include "igt_matrix.h" -#define m(row, col) ((col) * 4 + (row)) - /** * SECTION:igt_matrix * @short_description: Matrix math library @@ -110,29 +108,6 @@ struct igt_mat4 igt_matrix_translate(float x, float y, float z) return ret; } -/** - * igt_matrix_transform: - * - * Transform the vector @v by the matrix @m. @m is on the left, - * @v on the right. - * - * Returns: - * The transformed vector. - */ -struct igt_vec4 igt_matrix_transform(const struct igt_mat4 *m, - const struct igt_vec4 *v) -{ - struct igt_vec4 ret = {}; - - for (int row = 0; row < 4; row++) { - for (int i = 0; i < 4; i++) { - ret.d[row] += m->d[m(row, i)] * v->d[i]; - } - } - - return ret; -} - /** * igt_matrix_multiply: * -- cgit v1.2.3