From 937df2ef91e6cd524a9bfc54e973de465d587d54 Mon Sep 17 00:00:00 2001 From: Daniel Vetter Date: Wed, 13 Feb 2019 11:35:49 +0100 Subject: lib: Make sure we leak no child processes There's a lot more ways to leak children than igt_fork, some even handrolled. So check for that. Also have a nice littel testcase for that too. v2: Don't hang if there's a leaked child process (Chris). Has the added benefit that my library unit test also gets faster! v3: Rebase. Cc: Chris Wilson Reviewed-by: Chris Wilson Signed-off-by: Daniel Vetter --- lib/tests/igt_fork.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) (limited to 'lib/tests') diff --git a/lib/tests/igt_fork.c b/lib/tests/igt_fork.c index 1c10a801..fa5bb770 100644 --- a/lib/tests/igt_fork.c +++ b/lib/tests/igt_fork.c @@ -68,6 +68,20 @@ static void igt_fork_leak(void) } } +static void plain_fork_leak(void) +{ + int pid; + + switch (pid = fork()) { + case -1: + internal_assert(0); + case 0: + sleep(1); + default: + exit(0); + } +} + static void igt_fork_timeout_leak(void) { igt_fork(i, 1) { @@ -119,4 +133,8 @@ int main(int argc, char **argv) /* check that igt_waitchildren_timeout cleans up*/ ret = do_fork(igt_fork_timeout_leak); internal_assert(WEXITSTATUS(ret) == SIGKILL + 128); + + /* check that any other process leaks are caught*/ + ret = do_fork(plain_fork_leak); + internal_assert(WTERMSIG(ret) == SIGABRT); } -- cgit v1.2.3