From 55192ddf19444767c039386cae6864d934b35930 Mon Sep 17 00:00:00 2001 From: Simon Ser Date: Tue, 26 Mar 2019 15:32:30 +0200 Subject: tests/kms_chamelium: fix typo in check_analog_bridge This function checks whether a port is an analog bridge. Analog bridges provide their own EDID thus the vendor should be different from "IGT". There was a typo that made the function always return true for VGA ports. The condition was essentially: thing != 'I' || thing != 'T' which is always true. Apparently this didn't cause any harm, but it's probably better to fix it anyway in case some tests were skipped and shouldn't. Signed-off-by: Simon Ser Acked-by: Antonio Argenziano --- tests/kms_chamelium.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'tests/kms_chamelium.c') diff --git a/tests/kms_chamelium.c b/tests/kms_chamelium.c index c2090037..2dc1049d 100644 --- a/tests/kms_chamelium.c +++ b/tests/kms_chamelium.c @@ -199,7 +199,7 @@ check_analog_bridge(data_t *data, struct chamelium_port *port) /* Analog bridges provide their own EDID */ if (edid_vendor[0] != 'I' || edid_vendor[1] != 'G' || - edid_vendor[0] != 'T') + edid_vendor[2] != 'T') return true; return false; -- cgit v1.2.3