From 5e42c6232dab3a7bb96963aec5a9f90e169df20c Mon Sep 17 00:00:00 2001 From: Maarten Lankhorst Date: Thu, 21 Sep 2017 14:30:09 +0200 Subject: lib/igt_kms: Rework plane properties to be more atomic, v5. In the future I want to allow tests to commit more properties, but for this to work I have to fix all properties to work better with atomic commit. Instead of special casing each property make a bitmask for all property changed flags, and try to commit all properties. Changes since v1: - Remove special dumping of src and crtc coordinates. - Dump all modified coordinates. Changes since v2: - Move igt_plane_set_prop_changed up slightly. Changes since v3: - Fix wrong ordering of set_position in kms_plane_lowres causing a test failure. Changes since v4: - Back out resetting crtc position in igt_plane_set_fb() and document it during init. Tests appear to rely on it being preserved. Signed-off-by: Maarten Lankhorst Reviewed-by: Mika Kahola --- tests/kms_rotation_crc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'tests/kms_rotation_crc.c') diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c index 5aec8fa3..b8327dfa 100644 --- a/tests/kms_rotation_crc.c +++ b/tests/kms_rotation_crc.c @@ -122,11 +122,11 @@ static void prepare_crtc(data_t *data, igt_output_t *output, enum pipe pipe, igt_plane_set_fb(primary, &data->fb_modeset); if (commit < COMMIT_ATOMIC) { - primary->rotation_changed = false; + igt_plane_clear_prop_changed(primary, IGT_PLANE_ROTATION); igt_display_commit(display); if (plane->type == DRM_PLANE_TYPE_PRIMARY) - primary->rotation_changed = true; + igt_plane_set_prop_changed(primary, IGT_PLANE_ROTATION); } igt_plane_set_fb(plane, NULL); -- cgit v1.2.3