summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDmitry Fomin <fomindmitriyfoma@mail.ru>2023-02-25 21:43:22 +0300
committerTakashi Iwai <tiwai@suse.de>2023-03-03 14:30:46 +0100
commita8e98f3448e1a4b6848f213cf51720e29dcc774b (patch)
treef3e9282cb19dfddb4ebdfd16e9a21298c1b617ce
parent951606a14a8901e3551fe4d8d3cedd73fe954ce1 (diff)
ALSA: ice1712: Delete unreachable code in aureon_add_controls()
If the check (id != 0x41) fails, then id == 0x41 and the other check in 'else' branch also fails: id & 0x0F = 0b01000001 & 0b00001111 = 0b00000001. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Dmitry Fomin <fomindmitriyfoma@mail.ru> Link: https://lore.kernel.org/r/20230225184322.6286-2-fomindmitriyfoma@mail.ru Signed-off-by: Takashi Iwai <tiwai@suse.de>
-rw-r--r--sound/pci/ice1712/aureon.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/sound/pci/ice1712/aureon.c b/sound/pci/ice1712/aureon.c
index 40a0e0095030..24b978234000 100644
--- a/sound/pci/ice1712/aureon.c
+++ b/sound/pci/ice1712/aureon.c
@@ -1896,10 +1896,6 @@ static int aureon_add_controls(struct snd_ice1712 *ice)
if (id != 0x41)
dev_info(ice->card->dev,
"No CS8415 chip. Skipping CS8415 controls.\n");
- else if ((id & 0x0F) != 0x01)
- dev_info(ice->card->dev,
- "Detected unsupported CS8415 rev. (%c)\n",
- (char)((id & 0x0F) + 'A' - 1));
else {
for (i = 0; i < ARRAY_SIZE(cs8415_controls); i++) {
struct snd_kcontrol *kctl;