diff options
| author | Anil Kumar <anil.kumar@stericsson.com> | 2011-12-07 20:17:20 +0530 |
|---|---|---|
| committer | Philippe Langlais <philippe.langlais@stericsson.com> | 2012-05-22 11:02:37 +0200 |
| commit | 968a56fa5c7fef757cd1df008f68c2e6c8aee0c8 (patch) | |
| tree | 0327379ebe001ff3f2786182abefc63f3b439846 | |
| parent | c05cd72491c55e6158e23d94110a10cd11625863 (diff) | |
mach-ux500: board-mop500-uib: Fix coverity defect
Check for NULL return value unconditionally
to avoid dereferencing a NULL pointer
ST-Ericsson ID: 401383
ST-Ericsson Linux next: NA
ST-Ericsson FOSS-OUT ID: Trivial
Change-Id: I4035bf71f560bf0fbdd67d052068c8b05f3880f3
Signed-off-by: Anil Kumar <anil.kumar@stericsson.com>
Reviewed-on: http://gerrit.lud.stericsson.com/gerrit/41455
Reviewed-by: QATOOLS
Reviewed-by: QABUILD
Reviewed-by: Bibek BASU <bibek.basu@stericsson.com>
Reviewed-by: Jonas ABERG <jonas.aberg@stericsson.com>
| -rw-r--r-- | arch/arm/mach-ux500/board-mop500-uib.c | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/arch/arm/mach-ux500/board-mop500-uib.c b/arch/arm/mach-ux500/board-mop500-uib.c index 662edb639a2..908c5d973da 100644 --- a/arch/arm/mach-ux500/board-mop500-uib.c +++ b/arch/arm/mach-ux500/board-mop500-uib.c @@ -252,12 +252,13 @@ static int __init mop500_uib_init(void) I2C_SMBUS_QUICK, NULL); i2c_put_adapter(i2c0); i2c3 = i2c_get_adapter(3); + if (!i2c3) { + __mop500_uib_init(&mop500_uibs[STUIB], + "fallback, could not get i2c3"); + return -ENODEV; + } + if (ret == 0) { - if (!i2c3) { - __mop500_uib_init(&mop500_uibs[STUIB], - "fallback, could not get i2c3"); - return -ENODEV; - } ret = i2c_smbus_xfer(i2c3, 0x4B, 0, I2C_SMBUS_WRITE, 0, I2C_SMBUS_QUICK, NULL); i2c_put_adapter(i2c3); |