From 18e1aee4b43ad9d2de8e419f70304c0c75748c1b Mon Sep 17 00:00:00 2001 From: Bibek Basu Date: Wed, 2 Nov 2011 12:31:11 +0530 Subject: u5500 : mbox: wrong handling of atomic_dec_and_test atomic_dec_and_test wrongly used. ST-Ericsson Linux next: NA ST-Ericsson ID: 367390 ST-Ericsson FOSS-OUT ID: Trivial Change-Id: I37ffaa0afd6df3472469842925030e8a04a42a6b Signed-off-by: Bibek Basu Reviewed-on: http://gerrit.lud.stericsson.com/gerrit/36026 Reviewed-by: Srinidhi KASAGAR --- drivers/misc/mbox_channels-db5500.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/mbox_channels-db5500.c b/drivers/misc/mbox_channels-db5500.c index 43a4d57caaf..b3baae12d4b 100644 --- a/drivers/misc/mbox_channels-db5500.c +++ b/drivers/misc/mbox_channels-db5500.c @@ -379,7 +379,7 @@ rcv_msg: dev_err(&channels.pdev->dev, "%s no callback provided\n", __func__); } - if (atomic_dec_and_test(&rx_chan->rcv_counter) > 0) + if (!atomic_dec_and_test(&rx_chan->rcv_counter)) goto rcv_msg; } -- cgit v1.2.3