From 28aca83fac60b63d03c33428ea5cf02e0ae73523 Mon Sep 17 00:00:00 2001 From: Rajat Verma Date: Thu, 3 Nov 2011 14:53:28 +0530 Subject: staging: mmio: Corrects bug in buffer copy In copy_user_buffer(), result of "kmalloc()" called is checked against NULL as "if (!dest_buf)" whereas correct check must be "if (!*dest_buf)" as memory allocation is done against *dest_buf and not dest_buf. ST-Ericsson ID: 369361 ST-Ericsson FOSS-OUT ID: Trivial ST-Ericsson Linux next: NA Change-Id: I78971455a8aa3cb3b31a27572939f2e64fc4d65e Signed-off-by: Rajat Verma Reviewed-on: http://gerrit.lud.stericsson.com/gerrit/36170 Reviewed-by: Jonas ABERG --- drivers/staging/mmio/st_mmio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/mmio/st_mmio.c b/drivers/staging/mmio/st_mmio.c index 51e92666e28..a006c55c544 100644 --- a/drivers/staging/mmio/st_mmio.c +++ b/drivers/staging/mmio/st_mmio.c @@ -245,7 +245,7 @@ static int copy_user_buffer(void __iomem **dest_buf, *dest_buf = kmalloc(size, GFP_KERNEL); - if (!dest_buf) { + if (!*dest_buf) { err = -ENOMEM; goto nomem; } -- cgit v1.2.3