From 7dd431c4691793b86b628a0d2f0f7a11416eaa93 Mon Sep 17 00:00:00 2001 From: Durga Prasada Rao BATHINA Date: Wed, 24 Aug 2011 19:34:19 +0530 Subject: CAIF SHM: coverity issues dereferencing NULL pointer,if skb_dequeue returns NULL. ST-Ericsson ID: 358051 ST-Ericsson Linux next: NA ST-Ericsson FOSS-OUT ID: NA Change-Id: Ib88648e68c631cc8eaf839f96af7e847c12922b1 Signed-off-by: Durga Prasada Rao BATHINA Reviewed-on: http://gerrit.lud.stericsson.com/gerrit/31750 Reviewed-by: Bibek BASU Tested-by: Bibek BASU --- drivers/net/caif/caif_shmcore.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/caif/caif_shmcore.c b/drivers/net/caif/caif_shmcore.c index 27392cd05fd..7fe33417997 100644 --- a/drivers/net/caif/caif_shmcore.c +++ b/drivers/net/caif/caif_shmcore.c @@ -472,6 +472,8 @@ static void shm_tx_work_func(struct work_struct *tx_work) } skb = skb_dequeue(&pshm_drv->sk_qhead); + if (skb == NULL) + break; /* Copy in CAIF frame. */ skb_copy_bits(skb, 0, pbuf->desc_vptr + pbuf->frm_ofs + SHM_HDR_LEN + -- cgit v1.2.3