From a5041c72abedb8463f19b4667b4aa1595e3edb8e Mon Sep 17 00:00:00 2001 From: Aaron Pace Date: Mon, 26 Jul 2010 14:24:44 -0600 Subject: ext2fs: Fix optimization bug for doubly-indirect block pointers Doubly-indirect block numbers are compared against the first-level indirect block when checking for a cached copy. This is causing the doubly-indirect block to be re-read each time it is accessed. Repairing this reduces load time for a 70M file from 72 seconds to 38 seconds. Change-Id: I497e1f063f0d596d95171e42d1c39dc2c6aedf38 Signed-off-by: Aaron Pace Reviewed-on: http://gerrit.lud.stericsson.com/gerrit/3975 Tested-by: Michael BRANDT Reviewed-by: Sebastian RASMUSSEN Reviewed-by: Jonas ABERG Reviewed-by: Michael BRANDT --- fs/ext2/ext2fs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'fs') diff --git a/fs/ext2/ext2fs.c b/fs/ext2/ext2fs.c index 4b391d60a..a88cf8704 100644 --- a/fs/ext2/ext2fs.c +++ b/fs/ext2/ext2fs.c @@ -364,7 +364,7 @@ static int ext2fs_read_block (ext2fs_node_t node, int fileblock) { indir2_size = blksz; } if ((__le32_to_cpu (indir1_block[rblock / perblock]) << - log2_blksz) != indir1_blkno) { + log2_blksz) != indir2_blkno) { status = ext2fs_devread (__le32_to_cpu(indir1_block[rblock / perblock]) << log2_blksz, 0, blksz, (char *) indir2_block); -- cgit v1.2.3