diff options
| author | Chris Wilson <chris@chris-wilson.co.uk> | 2020-04-04 11:38:16 +0100 |
|---|---|---|
| committer | Chris Wilson <chris@chris-wilson.co.uk> | 2020-04-04 16:17:42 +0100 |
| commit | 4b617f43a90fad424da5948095522f62690d3bec (patch) | |
| tree | c4bc0752bc8474842944de295b7dd29a5c49d6ae | |
| parent | a5d16b60d7b66204ab8148bb712c59cec4e4ba0d (diff) | |
kms_flip: Skip interruptible testing for negative and hangs tests
Negative tests are API tests that will be rejected before we ever wait.
Repeating them expecting it to be interrupted is a forlorn hope.
Hang tests are expected to be blocked until they can be resolved by
hangcheck. Repeating those to see how a long wait responds when
interrupted is counter purpose, just a waste of time.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Andi Shyti <andi.shyti@intel.com>
| -rwxr-xr-x | tests/kms_flip.c | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/tests/kms_flip.c b/tests/kms_flip.c index 9ce83c53..c95838c7 100755 --- a/tests/kms_flip.c +++ b/tests/kms_flip.c @@ -1600,10 +1600,17 @@ igt_main continue; /* + * -EINVAL are negative API tests, they are rejected before + * any waits and so not subject to interruptiblity. + * * -EBUSY needs to complete in a single vblank, skip them for * interruptible tests + * + * HANGs are slow enough and interruptible hang testing is + * an oxymoron (can't force the wait-for-hang if being + * interrupted all the time). */ - if (tests[i].flags & TEST_EBUSY) + if (tests[i].flags & (TEST_EINVAL | TEST_EBUSY | TEST_HANG)) continue; igt_subtest_f( "%s-interruptible", tests[i].name) |