summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChris Wilson <chris@chris-wilson.co.uk>2020-04-06 16:25:19 +0100
committerChris Wilson <chris@chris-wilson.co.uk>2020-04-06 18:32:59 +0100
commit9c582425d6b4fc1de9fc2ffc8015cc6f0a0d3e98 (patch)
tree0d0d16afd6982c0e5ce843430bb19506355f2e53
parent0ed4376c09f0429a6a3e14694d07ca0bc1e57a19 (diff)
i915/i915_hangman: Drop last reference to bygone 'i915_error_state'
The test is looking at sysfs/error so dumping the old debugfs/i915_error_state looks quite silly. The only dilemma is whether it is worth replacing with a line-by-line dump. I propose we make that a future problem -- and leave it to whoever has to debug it next time. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Reviewed-by: Andi Shyti <andi.shyti@intel.com>
-rw-r--r--lib/igt_aux.c1
-rw-r--r--tests/i915/i915_hangman.c2
2 files changed, 0 insertions, 3 deletions
diff --git a/lib/igt_aux.c b/lib/igt_aux.c
index 1a564844..ecab5d99 100644
--- a/lib/igt_aux.c
+++ b/lib/igt_aux.c
@@ -484,7 +484,6 @@ hang_detector_process(int fd, pid_t pid, dev_t rdev)
str = udev_device_get_property_value(dev, "ERROR");
if (str && atoi(str) == 1) {
- igt_debugfs_dump(fd, "i915_error_state");
show_kernel_stack(pid);
kill(pid, SIGIO);
}
diff --git a/tests/i915/i915_hangman.c b/tests/i915/i915_hangman.c
index 08b06217..13cd6208 100644
--- a/tests/i915/i915_hangman.c
+++ b/tests/i915/i915_hangman.c
@@ -140,8 +140,6 @@ static void check_error_state(const char *expected_ring_name,
size_t line_size = 0;
bool found = false;
- igt_debugfs_dump(device, "i915_error_state");
-
igt_assert(getline(&line, &line_size, file) != -1);
igt_require(strcasecmp(line, "No error state collected"));