From 08822179e5e9d7ee7e76e1c912e45193f38c8cd7 Mon Sep 17 00:00:00 2001 From: Petri Latvala Date: Fri, 18 Jan 2019 12:42:10 +0200 Subject: lib/i915/gem_context: Help static analysis with execution flow MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit If an igt_ioctl fails, errno is set to non-zero, and static analysis doesn't quite get it. Add an igt_assume() to help. v2: Braces on both branches of an if (Chris) Signed-off-by: Petri Latvala Cc: Chris Wilson Cc: Michał Winiarski Reviewed-by: Chris Wilson --- lib/i915/gem_context.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'lib/i915') diff --git a/lib/i915/gem_context.c b/lib/i915/gem_context.c index 669bd318..16004685 100644 --- a/lib/i915/gem_context.c +++ b/lib/i915/gem_context.c @@ -80,10 +80,12 @@ int __gem_context_create(int fd, uint32_t *ctx_id) int err = 0; memset(&create, 0, sizeof(create)); - if (igt_ioctl(fd, DRM_IOCTL_I915_GEM_CONTEXT_CREATE, &create) == 0) + if (igt_ioctl(fd, DRM_IOCTL_I915_GEM_CONTEXT_CREATE, &create) == 0) { *ctx_id = create.ctx_id; - else - err = -errno; + } else { + err = -errno; + igt_assume(err != 0); + } errno = 0; return err; -- cgit v1.2.3