From 94e886203a99ef19b8319489a45cd348e76e8ccd Mon Sep 17 00:00:00 2001 From: Antonio Argenziano Date: Mon, 19 Mar 2018 15:30:38 -0700 Subject: igt: Replace 'all-engines' magic numbers with macro In interfaces where a parameter allow to select an engine, we usually use '-1' or '~0u' to select all engines. This patch replaces magic numbers with a named constant. Suggested-by: Chris Wilson Signed-off-by: Antonio Argenziano Cc: Chris Wilson Reviewed-by: Chris Wilson --- lib/i915/gem_submission.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'lib/i915') diff --git a/lib/i915/gem_submission.c b/lib/i915/gem_submission.c index e27ea9ec..c5e96969 100644 --- a/lib/i915/gem_submission.c +++ b/lib/i915/gem_submission.c @@ -177,8 +177,8 @@ static bool is_wedged(int i915) * @i915: open i915 drm file descriptor * @engine: the engine (I915_EXEC_RING id) to exercise * - * Execute a nop batch on the specified, or -1 for all, and check it - * executes. + * Execute a nop batch on the engine specified, or ALL_ENGINES for all, + * and check it executes. */ void gem_test_engine(int i915, unsigned int engine) { @@ -194,7 +194,7 @@ void gem_test_engine(int i915, unsigned int engine) igt_assert(!is_wedged(i915)); gem_write(i915, obj.handle, 0, &bbe, sizeof(bbe)); - if (engine == -1u) { + if (engine == ALL_ENGINES) { for_each_engine(i915, engine) { execbuf.flags = engine; gem_execbuf(i915, &execbuf); -- cgit v1.2.3