From 764160f214cd916ddb79408b9f28ac0ad2df40e0 Mon Sep 17 00:00:00 2001 From: Ville Syrjälä Date: Fri, 6 Jul 2018 19:35:50 +0300 Subject: lib/igt_draw: Zero initalize the igt_bufs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit I missed these when sprinkling the memsets. Using stack garbage as the aux surface state isn't a good idea. Causes kms_front_buffer_tracking to fail on skl+. Fixes: a4393c3951ec ("lib: Add aux surface state to igt_buf") Signed-off-by: Ville Syrjälä Reviewed-by: Chris Wilson Reviewed-by: Antonio Argenziano --- lib/igt_draw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib/igt_draw.c') diff --git a/lib/igt_draw.c b/lib/igt_draw.c index ebae9151..c7d5770d 100644 --- a/lib/igt_draw.c +++ b/lib/igt_draw.c @@ -568,7 +568,7 @@ static void draw_rect_render(int fd, struct cmd_data *cmd_data, drm_intel_bo *src, *dst; uint32_t devid = intel_get_drm_devid(fd); igt_render_copyfunc_t rendercopy = igt_get_render_copyfunc(devid); - struct igt_buf src_buf, dst_buf; + struct igt_buf src_buf = {}, dst_buf = {}; struct intel_batchbuffer *batch; uint32_t tiling, swizzle; struct buf_data tmp; -- cgit v1.2.3