From 0a3ef582daa961047dabf3008177f60db8984b03 Mon Sep 17 00:00:00 2001 From: Ville Syrjälä Date: Thu, 5 Feb 2015 16:12:11 +0200 Subject: lib: Change IOSF SB devfn to 0.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The devfn field in the IOSF SB messages is only relevant when there's a real PCI bus or some other multifunction device behind a single port. Otherwise the port number itself is enough to uniquely identify the target. In fact some IOSF SB targets reject the access when devfn is not 0.0 (eg. GPIO_NC on BYT). Signed-off-by: Ville Syrjälä --- lib/intel_iosf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib/intel_iosf.c') diff --git a/lib/intel_iosf.c b/lib/intel_iosf.c index 27134a07..01577cd0 100644 --- a/lib/intel_iosf.c +++ b/lib/intel_iosf.c @@ -28,7 +28,7 @@ static int vlv_sideband_rw(uint32_t port, uint8_t opcode, uint32_t addr, bar = 0; be = 0xf; - devfn = 16; + devfn = 0; cmd = (devfn << IOSF_DEVFN_SHIFT) | (opcode << IOSF_OPCODE_SHIFT) | (port << IOSF_PORT_SHIFT) | (be << IOSF_BYTE_ENABLES_SHIFT) | -- cgit v1.2.3