From cfb04c4a6171575f8782fe1dd5c63700ad33799e Mon Sep 17 00:00:00 2001 From: Petri Latvala Date: Mon, 1 Feb 2021 08:33:39 +0200 Subject: meson: Turn off -Werror No, we don't want all warnings ever to be errors. While being rid of compile warnings (especially the more obscure ones from future compilers) is great, having it on always is not acceptable. It's not even on "by default", it was non-overrideably set on. Not to mention adding -Werror to compiler flags is the incorrect way of turning it on. Use the meson command line flag --werror instead on whatever local checkout or company-internal fork you're using, where you have control over which compilers are used. Turning it on unconditionally in an upstream repository for all current and future compilers is never ok. This partially reverts commit e02612921a4e95aef3a368e7468f4337c9dcee7d. Signed-off-by: Petri Latvala Cc: Ashutosh Dixit Cc: Chris Wilson Cc: Arkadiusz Hiler Reviewed-by: Chris Wilson --- meson.build | 28 +++++++++++++--------------- 1 file changed, 13 insertions(+), 15 deletions(-) (limited to 'meson.build') diff --git a/meson.build b/meson.build index 3f3693f9..f4ee14f1 100644 --- a/meson.build +++ b/meson.build @@ -51,21 +51,19 @@ cc_args = [ '-Wno-unused-parameter', '-Wno-unused-result', - '-Waddress', - '-Warray-bounds', - '-Wimplicit', - '-Winit-self', - '-Wint-to-pointer-cast', - '-Wmain', - '-Wmissing-braces', - '-Wnonnull', - '-Wpointer-to-int-cast', - '-Wreturn-type', - '-Wsequence-point', - '-Wtrigraphs', - '-Wwrite-strings', - - '-Werror', + '-Werror=address', + '-Werror=array-bounds', + '-Werror=implicit', + '-Werror=init-self', + '-Werror=int-to-pointer-cast', + '-Werror=main', + '-Werror=missing-braces', + '-Werror=nonnull', + '-Werror=pointer-to-int-cast', + '-Werror=return-type', + '-Werror=sequence-point', + '-Werror=trigraphs', + '-Werror=write-strings', # Disable the memory allocating builtins as they may cause unexpected behavior # with our framework. They *may* get optimized out in favor of a register or # stack variable, making them effectively local. Local variables do not play -- cgit v1.2.3