From 5e42c6232dab3a7bb96963aec5a9f90e169df20c Mon Sep 17 00:00:00 2001 From: Maarten Lankhorst Date: Thu, 21 Sep 2017 14:30:09 +0200 Subject: lib/igt_kms: Rework plane properties to be more atomic, v5. In the future I want to allow tests to commit more properties, but for this to work I have to fix all properties to work better with atomic commit. Instead of special casing each property make a bitmask for all property changed flags, and try to commit all properties. Changes since v1: - Remove special dumping of src and crtc coordinates. - Dump all modified coordinates. Changes since v2: - Move igt_plane_set_prop_changed up slightly. Changes since v3: - Fix wrong ordering of set_position in kms_plane_lowres causing a test failure. Changes since v4: - Back out resetting crtc position in igt_plane_set_fb() and document it during init. Tests appear to rely on it being preserved. Signed-off-by: Maarten Lankhorst Reviewed-by: Mika Kahola --- tests/kms_atomic_interruptible.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'tests/kms_atomic_interruptible.c') diff --git a/tests/kms_atomic_interruptible.c b/tests/kms_atomic_interruptible.c index dcdbc267..4a2a5774 100644 --- a/tests/kms_atomic_interruptible.c +++ b/tests/kms_atomic_interruptible.c @@ -163,12 +163,12 @@ static void run_plane_test(igt_display_t *display, enum pipe pipe, igt_output_t /* connector: 1 prop */ output->props[IGT_CONNECTOR_CRTC_ID], /* plane: remainder props */ - plane->atomic_props_plane[IGT_PLANE_CRTC_ID], - plane->atomic_props_plane[IGT_PLANE_FB_ID], - plane->atomic_props_plane[IGT_PLANE_SRC_W], - plane->atomic_props_plane[IGT_PLANE_SRC_H], - plane->atomic_props_plane[IGT_PLANE_CRTC_W], - plane->atomic_props_plane[IGT_PLANE_CRTC_H] + plane->props[IGT_PLANE_CRTC_ID], + plane->props[IGT_PLANE_FB_ID], + plane->props[IGT_PLANE_SRC_W], + plane->props[IGT_PLANE_SRC_H], + plane->props[IGT_PLANE_CRTC_W], + plane->props[IGT_PLANE_CRTC_H] }; uint64_t prop_vals[] = { /* crtc */ -- cgit v1.2.3