From 0eb4d05ea1148672086972e5dc2506a8d2002ce6 Mon Sep 17 00:00:00 2001 From: Dhinakaran Pandiyan Date: Wed, 5 Sep 2018 14:15:56 -0700 Subject: tests/psr: Avoid opening of already open debugfs dir MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The tests calls igt_debugfs_dir() to open the debugfs dir and further along calls igt_debugfs_read() each time i915_edp_psr_status needs to be read. As igt_debugfs_read() opens the directory unnecessarily, switch to using the newly added igt_debugfs_simple_read() v2: Commit message typo (Jose) Signed-off-by: Dhinakaran Pandiyan Reviewed-by: José Roberto de Souza --- tests/kms_psr.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) (limited to 'tests/kms_psr.c') diff --git a/tests/kms_psr.c b/tests/kms_psr.c index 218b3960..3e64cf04 100644 --- a/tests/kms_psr.c +++ b/tests/kms_psr.c @@ -192,7 +192,8 @@ static bool sink_support(data_t *data) { char buf[512]; - igt_debugfs_read(data->drm_fd, "i915_edp_psr_status", buf); + igt_debugfs_simple_read(data->debugfs_fd, "i915_edp_psr_status", + buf, sizeof(buf)); return data->with_psr_disabled || strstr(buf, "Sink_Support: yes\n"); @@ -203,7 +204,7 @@ static bool psr_wait_entry_if_enabled(data_t *data) if (data->with_psr_disabled) return true; - return psr_wait_entry(data->drm_fd); + return psr_wait_entry(data->debugfs_fd); } static inline void manual(const char *expected) @@ -215,7 +216,8 @@ static bool drrs_disabled(data_t *data) { char buf[512]; - igt_debugfs_read(data->drm_fd, "i915_drrs_status", buf); + igt_debugfs_simple_read(data->debugfs_fd, "i915_drrs_status", + buf, sizeof(buf)); return !strstr(buf, "DRRS Supported: Yes\n"); } @@ -292,7 +294,7 @@ static void run_test(data_t *data) expected = "screen GREEN"; break; } - igt_assert(psr_active(data->drm_fd, false)); + igt_assert(psr_active(data->debugfs_fd, false)); manual(expected); } -- cgit v1.2.3