From c829766f3651c207e6fa4d38aaa7359ae276fb6c Mon Sep 17 00:00:00 2001 From: Chris Wilson Date: Tue, 4 Sep 2018 19:38:46 +0100 Subject: igt/kms_vblank: Exercise some EINVAL Feed some impossible garbage into drmWaitVblank and expect the kernel to report EINVAL. v2: Cancel the double negative of ~invalid_flags Signed-off-by: Chris Wilson Cc: Daniel Vetter Reviewed-by: Daniel Vetter --- tests/kms_vblank.c | 45 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) (limited to 'tests/kms_vblank.c') diff --git a/tests/kms_vblank.c b/tests/kms_vblank.c index b3cd2d93..1c0771c6 100644 --- a/tests/kms_vblank.c +++ b/tests/kms_vblank.c @@ -455,6 +455,48 @@ static void run_subtests_for_pipe(data_t *data) } } +static void invalid_subtest(data_t *data, int fd) +{ + union drm_wait_vblank vbl; + unsigned long valid_flags; + + igt_display_require_output_on_pipe(&data->display, 0); + + /* First check all is well with a simple query */ + memset(&vbl, 0, sizeof(vbl)); + vbl.request.type = DRM_VBLANK_RELATIVE; + igt_assert_eq(wait_vblank(fd, &vbl), 0); + + valid_flags = (_DRM_VBLANK_TYPES_MASK | + _DRM_VBLANK_FLAGS_MASK | + _DRM_VBLANK_HIGH_CRTC_MASK); + + /* pick some interesting invalid permutations */ + memset(&vbl, 0, sizeof(vbl)); + vbl.request.type = _DRM_VBLANK_RELATIVE | ~valid_flags; + igt_assert_eq(wait_vblank(fd, &vbl), -EINVAL); + for (int bit = 0; bit < 32; bit++) { + int err; + + if (valid_flags & (1 << bit)) + continue; + + memset(&vbl, 0, sizeof(vbl)); + vbl.request.type = _DRM_VBLANK_RELATIVE | (1 << bit); + err = wait_vblank(fd, &vbl); + igt_assert_f(err == -EINVAL, + "vblank wait with invalid request.type bit %d [0x%08x] did not report -EINVAL, got %d\n", + bit, 1 << bit, err); + } + + /* check the maximum pipe, nobody should have that many pipes! */ + memset(&vbl, 0, sizeof(vbl)); + vbl.request.type = _DRM_VBLANK_RELATIVE; + vbl.request.type |= _DRM_VBLANK_SECONDARY; + vbl.request.type |= _DRM_VBLANK_FLAGS_MASK; + igt_assert_eq(wait_vblank(fd, &vbl), -EINVAL); +} + igt_main { int fd; @@ -469,6 +511,9 @@ igt_main igt_display_require_output(&data.display); } + igt_subtest("invalid") + invalid_subtest(&data, fd); + igt_subtest("crtc-id") crtc_id_subtest(&data, fd); -- cgit v1.2.3