summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPavel Begunkov <asml.silence@gmail.com>2021-09-24 22:00:03 +0100
committerJens Axboe <axboe@kernel.dk>2021-10-19 05:49:54 -0600
commita1cdbb4cb5f7190c429b1127892f756b7cd32db4 (patch)
tree00b954eaa60f428177d3de798419654b88765b78
parentef05d9ebcc927260f700a94436e7c9347657bbef (diff)
io_uring: comment why inline complete calls io_clean_op()
io_req_complete_state() calls io_clean_op() and it may be not entirely obvious, leave a comment. Signed-off-by: Pavel Begunkov <asml.silence@gmail.com> Link: https://lore.kernel.org/r/21806f862151e223fdf439e5e8ed7178a8d66979.1632516769.git.asml.silence@gmail.com Signed-off-by: Jens Axboe <axboe@kernel.dk>
-rw-r--r--fs/io_uring.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/io_uring.c b/fs/io_uring.c
index eff24d8eb399..5a06063d5d81 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -1822,6 +1822,7 @@ static void io_req_complete_state(struct io_kiocb *req, long res,
{
struct io_submit_state *state;
+ /* clean per-opcode space, because req->compl is aliased with it */
if (io_req_needs_clean(req))
io_clean_op(req);
req->result = res;