diff options
author | Vineet Gupta <vgupta@synopsys.com> | 2016-01-08 12:29:10 +0530 |
---|---|---|
committer | Vineet Gupta <vgupta@synopsys.com> | 2016-01-22 17:25:03 +0530 |
commit | cbfe74a753e877b49dc54e9b04d5d42230ca0aed (patch) | |
tree | 44a68deb843b381bb776ee0af5a6275af467e3e5 /arch/arc/include/asm/mcip.h | |
parent | afd2ff9b7e1b367172f18ba7f693dfb62bdcb2dc (diff) |
ARCv2: STAR 9000950267: Handle return from intr to Delay Slot #2
Returning to delay slot, riding an interrupti, had one loose end.
AUX_USER_SP used for restoring user mode SP upon RTIE was not being
setup from orig task's saved value, causing task to use wrong SP,
leading to ProtV errors.
The reason being:
- INTERRUPT_EPILOGUE returns to a kernel trampoline, thus not expected to restore it
- EXCEPTION_EPILOGUE is not used at all
Fix that by restoring AUX_USER_SP explicitly in the trampoline.
This was broken in the original workaround, but the error scenarios got
reduced considerably since v3.14 due to following:
1. The Linuxthreads.old based userspace at the time caused many more
exceptions in delay slot than the current NPTL based one.
Infact with current userspace the error doesn't happen at all.
2. Return from interrupt (delay slot or otherwise) doesn't get exercised much
after commit 4de0e52867d8 ("Really Re-enable interrupts to avoid deadlocks")
since IRQ_ACTIVE.active being clear means most returns are as if from pure
kernel (even for active interrupts)
Infact the issue only happened in an experimental branch where I was tinkering with
reverted 4de0e52867d8
Cc: stable@kernel.org # v4.2+
Fixes: 4255b07f2c9c ("ARCv2: STAR 9000793984: Handle return from intr to Delay Slot")
Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
Diffstat (limited to 'arch/arc/include/asm/mcip.h')
0 files changed, 0 insertions, 0 deletions