summaryrefslogtreecommitdiff
path: root/drivers/gpio/gpio-da9052.c
diff options
context:
space:
mode:
authorArnd Bergmann <arnd@arndb.de>2016-03-14 15:22:25 +0100
committerSeung-Woo Kim <sw0312.kim@samsung.com>2016-12-14 13:54:16 +0900
commitd6e65d423508084a810c4990312e4842645c4ff1 (patch)
tree8259b484dff6669d3f849cca6dba0a2481a628b8 /drivers/gpio/gpio-da9052.c
parent09c74aecd5ddf625e7354b4cb13fa0f811a1977d (diff)
drm/exynos: fix error handling in exynos_drm_subdrv_open
gcc-6 warns about a pointless loop in exynos_drm_subdrv_open: drivers/gpu/drm/exynos/exynos_drm_core.c: In function 'exynos_drm_subdrv_open': drivers/gpu/drm/exynos/exynos_drm_core.c:104:199: error: self-comparison always evaluates to false [-Werror=tautological-compare] list_for_each_entry_reverse(subdrv, &subdrv->list, list) { Here, the list_for_each_entry_reverse immediately terminates because the subdrv pointer is compared to itself as the loop end condition. If we were to take the current subdrv pointer as the start of the list (as we would do if list_for_each_entry_reverse() was not a macro), we would iterate backwards over the &exynos_drm_subdrv_list anchor, which would be even worse. Instead, we need to use list_for_each_entry_continue_reverse() to go back over each subdrv that was successfully opened until the first entry. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Inki Dae <inki.dae@samsung.com> [Backport from mainline to fix build warning with gcc6] Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com> Change-Id: Iee4b9078f0bd521507716521a339b37ea5dd8776
Diffstat (limited to 'drivers/gpio/gpio-da9052.c')
0 files changed, 0 insertions, 0 deletions