diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2021-08-13 14:36:00 +0300 |
|---|---|---|
| committer | Rodrigo Vivi <rodrigo.vivi@intel.com> | 2021-08-20 12:32:38 -0400 |
| commit | ff12ce2c9cb1cd09017151424db66de803984abc (patch) | |
| tree | a46a856e49db7a2b618ebe438ad67af0aaf02e53 /drivers/gpu/drm/i915/gt/intel_migrate.c | |
| parent | 8c3363c67b885fe40f50a8010a0768c4fd1e4b95 (diff) | |
drm/i915/gt: Potential error pointer dereference in pinned_context()
If the intel_engine_create_pinned_context() function returns an error
pointer, then dereferencing "ce" will Oops. Use "vm" instead of
"ce->vm".
Fixes: cf586021642d ("drm/i915/gt: Pipelined page migration")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210813113600.GC30697@kili
Diffstat (limited to 'drivers/gpu/drm/i915/gt/intel_migrate.c')
| -rw-r--r-- | drivers/gpu/drm/i915/gt/intel_migrate.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c index d0a7c934fd3b..1dac21aa7e5c 100644 --- a/drivers/gpu/drm/i915/gt/intel_migrate.c +++ b/drivers/gpu/drm/i915/gt/intel_migrate.c @@ -177,7 +177,7 @@ static struct intel_context *pinned_context(struct intel_gt *gt) ce = intel_engine_create_pinned_context(engine, vm, SZ_512K, I915_GEM_HWS_MIGRATE, &key, "migrate"); - i915_vm_put(ce->vm); + i915_vm_put(vm); return ce; } |