summaryrefslogtreecommitdiff
path: root/drivers/i3c
diff options
context:
space:
mode:
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>2021-01-28 10:10:48 +0100
committerAlexandre Belloni <alexandre.belloni@bootlin.com>2021-02-02 00:16:57 +0100
commitdd9267034c0e364b49261c3e0070b863286d1242 (patch)
tree2d1206e6de7b4028d9a472d4b03f8e6e3a770b1f /drivers/i3c
parent7456fea589c6ad3422b0c188871ae80e1d307737 (diff)
i3c: Make remove callback return void
The driver core ignores the return value of struct bus_type::remove() because there is only little that can be done. To simplify the quest to make this function return void, let struct i3c_driver::remove() return void, too. This makes it obvious that returning an error code is a bad idea and future driver authors cannot get that wrong. Up to now there are no drivers with a remove callback, so there is no need to adapt drivers. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Link: https://lore.kernel.org/r/20210128091048.17006-2-u.kleine-koenig@pengutronix.de
Diffstat (limited to 'drivers/i3c')
-rw-r--r--drivers/i3c/master.c10
1 files changed, 3 insertions, 7 deletions
diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
index 57a4f699eb8d..f8e9b7305c13 100644
--- a/drivers/i3c/master.c
+++ b/drivers/i3c/master.c
@@ -326,17 +326,13 @@ static int i3c_device_remove(struct device *dev)
{
struct i3c_device *i3cdev = dev_to_i3cdev(dev);
struct i3c_driver *driver = drv_to_i3cdrv(dev->driver);
- int ret = 0;
- if (driver->remove) {
- ret = driver->remove(i3cdev);
- if (ret)
- return ret;
- }
+ if (driver->remove)
+ driver->remove(i3cdev);
i3c_device_free_ibi(i3cdev);
- return ret;
+ return 0;
}
struct bus_type i3c_bus_type = {