summaryrefslogtreecommitdiff
path: root/drivers/pwm/pwm-lpss-platform.c
diff options
context:
space:
mode:
authorHans de Goede <hdegoede@redhat.com>2020-09-03 13:23:23 +0200
committerHans de Goede <hdegoede@redhat.com>2020-09-06 15:37:58 +0200
commit181f4d2f44463fe09fe4df02e03095cb87151c29 (patch)
tree6ebda6c23394d91934c4e10bf334c6c9cdcee46b /drivers/pwm/pwm-lpss-platform.c
parent15aa5e4c4328c4060cc662105a7b4c107a072ff3 (diff)
pwm: lpss: Fix off by one error in base_unit math in pwm_lpss_prepare()
According to the data-sheet the way the PWM controller works is that each input clock-cycle the base_unit gets added to a N bit counter and that counter overflowing determines the PWM output frequency. So assuming e.g. a 16 bit counter this means that if base_unit is set to 1, after 65535 input clock-cycles the counter has been increased from 0 to 65535 and it will overflow on the next cycle, so it will overflow after every 65536 clock cycles and thus the calculations done in pwm_lpss_prepare() should use 65536 and not 65535. This commit fixes this. Note this also aligns the calculations in pwm_lpss_prepare() with those in pwm_lpss_get_state(). Note this effectively reverts commit 684309e5043e ("pwm: lpss: Avoid potential overflow of base_unit"). The next patch in this series really fixes the potential overflow of the base_unit value. Fixes: 684309e5043e ("pwm: lpss: Avoid potential overflow of base_unit") Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Thierry Reding <thierry.reding@gmail.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com> Link: https://patchwork.freedesktop.org/patch/msgid/20200903112337.4113-4-hdegoede@redhat.com
Diffstat (limited to 'drivers/pwm/pwm-lpss-platform.c')
0 files changed, 0 insertions, 0 deletions