diff options
author | zhouchuangao <zhouchuangao@vivo.com> | 2021-05-12 07:01:57 -0700 |
---|---|---|
committer | Jessica Yu <jeyu@kernel.org> | 2021-05-14 09:50:56 +0200 |
commit | 02b2fb455b2e80a0a831d067ab7ef950e2991eee (patch) | |
tree | ffdbab3ce2111566035c44fc5e8b07a8daaa4129 /lib/test_bitops.c | |
parent | 6efb943b8616ec53a5e444193dccf1af9ad627b5 (diff) |
kernel/module: Use BUG_ON instead of if condition followed by BUG
Fix the following coccinelle report:
kernel/module.c:1018:2-5:
WARNING: Use BUG_ON instead of if condition followed by BUG.
BUG_ON uses unlikely in if(). Through disassembly, we can see that
brk #0x800 is compiled to the end of the function.
As you can see below:
......
ffffff8008660bec: d65f03c0 ret
ffffff8008660bf0: d4210000 brk #0x800
Usually, the condition in if () is not satisfied. For the
multi-stage pipeline, we do not need to perform fetch decode
and excute operation on brk instruction.
In my opinion, this can improve the efficiency of the
multi-stage pipeline.
Signed-off-by: zhouchuangao <zhouchuangao@vivo.com>
Signed-off-by: Jessica Yu <jeyu@kernel.org>
Diffstat (limited to 'lib/test_bitops.c')
0 files changed, 0 insertions, 0 deletions