diff options
| author | Anthony Romano <anthony.romano@coreos.com> | 2016-06-24 14:48:43 -0700 |
|---|---|---|
| committer | Sasha Levin <sasha.levin@oracle.com> | 2016-07-10 22:27:10 -0400 |
| commit | c5bcec6cbcbf520f088dc7939934bbf10c20c5a5 (patch) | |
| tree | 598927753c5d5399749236d28c7652b801f11e1a /mm | |
| parent | 7f3724b8951735ef1d5ae4f2846b8af98a665d73 (diff) | |
tmpfs: don't undo fallocate past its last page
[ Upstream commit b9b4bb26af017dbe930cd4df7f9b2fc3a0497bfe ]
When fallocate is interrupted it will undo a range that extends one byte
past its range of allocated pages. This can corrupt an in-use page by
zeroing out its first byte. Instead, undo using the inclusive byte
range.
Fixes: 1635f6a74152f1d ("tmpfs: undo fallocation on failure")
Link: http://lkml.kernel.org/r/1462713387-16724-1-git-send-email-anthony.romano@coreos.com
Signed-off-by: Anthony Romano <anthony.romano@coreos.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Hugh Dickins <hughd@google.com>
Cc: Brandon Philips <brandon@ifup.co>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Diffstat (limited to 'mm')
| -rw-r--r-- | mm/shmem.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/mm/shmem.c b/mm/shmem.c index 47d536e59fc0..86c150bf8235 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -2139,7 +2139,7 @@ static long shmem_fallocate(struct file *file, int mode, loff_t offset, /* Remove the !PageUptodate pages we added */ shmem_undo_range(inode, (loff_t)start << PAGE_CACHE_SHIFT, - (loff_t)index << PAGE_CACHE_SHIFT, true); + ((loff_t)index << PAGE_CACHE_SHIFT) - 1, true); goto undone; } |