diff options
| author | Vladimir Oltean <vladimir.oltean@nxp.com> | 2022-04-15 18:46:23 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-04-20 10:34:34 +0100 |
| commit | b2033a05a7197f5ddef617be8f510c9957a82553 (patch) | |
| tree | 54d777446a1a8ecd8fc0265ec6284595a0a619fd /net/dsa | |
| parent | 726816a129cbb1d645ed319a6f181f152f0dbda8 (diff) | |
net: dsa: use dsa_tree_for_each_user_port in dsa_slave_change_mtu
Use the more conventional iterator over user ports instead of explicitly
ignoring them, and use the more conventional name "other_dp" instead of
"dp_iter", for readability.
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/dsa')
| -rw-r--r-- | net/dsa/slave.c | 13 |
1 files changed, 5 insertions, 8 deletions
diff --git a/net/dsa/slave.c b/net/dsa/slave.c index 41c69a6e7854..da234c4b7daa 100644 --- a/net/dsa/slave.c +++ b/net/dsa/slave.c @@ -1808,7 +1808,7 @@ int dsa_slave_change_mtu(struct net_device *dev, int new_mtu) struct dsa_port *dp = dsa_slave_to_port(dev); struct dsa_slave_priv *p = netdev_priv(dev); struct dsa_switch *ds = p->dp->ds; - struct dsa_port *dp_iter; + struct dsa_port *other_dp; struct dsa_port *cpu_dp; int port = p->dp->index; int largest_mtu = 0; @@ -1821,26 +1821,23 @@ int dsa_slave_change_mtu(struct net_device *dev, int new_mtu) if (!ds->ops->port_change_mtu) return -EOPNOTSUPP; - list_for_each_entry(dp_iter, &ds->dst->ports, list) { + dsa_tree_for_each_user_port(other_dp, ds->dst) { int slave_mtu; - if (!dsa_port_is_user(dp_iter)) - continue; - /* During probe, this function will be called for each slave * device, while not all of them have been allocated. That's * ok, it doesn't change what the maximum is, so ignore it. */ - if (!dp_iter->slave) + if (!other_dp->slave) continue; /* Pretend that we already applied the setting, which we * actually haven't (still haven't done all integrity checks) */ - if (dp_iter == dp) + if (dp == other_dp) slave_mtu = new_mtu; else - slave_mtu = dp_iter->slave->mtu; + slave_mtu = other_dp->slave->mtu; if (largest_mtu < slave_mtu) largest_mtu = slave_mtu; |