From 646c3ae9d96fb92dda2b30b970d89c2a326f2749 Mon Sep 17 00:00:00 2001 From: Bhumika Goyal Date: Tue, 13 Dec 2016 09:49:45 -0200 Subject: [media] media: i2c: m5mols: m5mols_core: constify v4l2_subdev_pad_ops structures v4l2_subdev_pad_ops structures are stored in the pad field of the v4l2_subdev_ops structure and this field is of type const. As the v4l2_subdev_pad_ops structures are never modified, they can be declared as const. Done using Coccinelle: @r1 disable optional_qualifier @ identifier i; position p; @@ static struct v4l2_subdev_pad_ops i@p = {...}; @ok1@ identifier r1.i; position p; struct v4l2_subdev_ops obj; @@ obj.pad=&i@p; @bad@ position p!={r1.p,ok1.p}; identifier r1.i; @@ i@p @depends on !bad disable optional_qualifier@ identifier r1.i; @@ +const struct v4l2_subdev_pad_ops i; File size before: text data bss dec hex filename 7633 512 20 8165 1fe5 media/i2c/m5mols/m5mols_core.o File size after: text data bss dec hex filename 7761 384 20 8165 1fe5 media/i2c/m5mols/m5mols_core.o Signed-off-by: Bhumika Goyal Signed-off-by: Mauro Carvalho Chehab --- drivers/media/i2c/m5mols/m5mols_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'drivers') diff --git a/drivers/media/i2c/m5mols/m5mols_core.c b/drivers/media/i2c/m5mols/m5mols_core.c index 23e86164611c..9ccb5ee55fa9 100644 --- a/drivers/media/i2c/m5mols/m5mols_core.c +++ b/drivers/media/i2c/m5mols/m5mols_core.c @@ -652,7 +652,7 @@ static int m5mols_enum_mbus_code(struct v4l2_subdev *sd, return 0; } -static struct v4l2_subdev_pad_ops m5mols_pad_ops = { +static const struct v4l2_subdev_pad_ops m5mols_pad_ops = { .enum_mbus_code = m5mols_enum_mbus_code, .get_fmt = m5mols_get_fmt, .set_fmt = m5mols_set_fmt, -- cgit v1.2.3