summaryrefslogtreecommitdiff
path: root/drivers/misc/bh1780gli.c
diff options
context:
space:
mode:
authorChethan Krishna N <chethan.krishna@stericsson.com>2011-03-15 11:58:24 +0530
committerPhilippe Langlais <philippe.langlais@stericsson.com>2012-05-22 10:59:45 +0200
commit031147f98e9dd4b28f397cb0469b9d15400ae953 (patch)
tree7f862dd05a93b712b50dcc1e2af0dfb6108df5d9 /drivers/misc/bh1780gli.c
parentb8f207b56a72f894f033388ec88ed95ad2cd0bf4 (diff)
bh1780gli: correct mutex locking behaviour
Multiple activation and deactivation calls for BH1780GLI Ambient Light Sensor will not crash now. ST Ericsson ID: ER326054 Signed-off-by: Chethan Krishna N <chethan.krishna@stericsson.com> Change-Id: I3bfeb6a371ae567e14300339b1b18dc750a59b14 Reviewed-on: http://gerrit.lud.stericsson.com/gerrit/18319 Reviewed-by: Srinidhi KASAGAR <srinidhi.kasagar@stericsson.com>
Diffstat (limited to 'drivers/misc/bh1780gli.c')
-rw-r--r--drivers/misc/bh1780gli.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/misc/bh1780gli.c b/drivers/misc/bh1780gli.c
index a7c012a6545..0b9ff5e8825 100644
--- a/drivers/misc/bh1780gli.c
+++ b/drivers/misc/bh1780gli.c
@@ -116,11 +116,11 @@ static ssize_t bh1780_store_power_state(struct device *dev,
if (val < BH1780_POFF || val > BH1780_PON)
return -EINVAL;
- mutex_lock(&ddata->lock);
-
if (ddata->power_state == val)
return count;
+ mutex_lock(&ddata->lock);
+
if (ddata->power_state == BH1780_POFF)
regulator_enable(ddata->regulator);