diff options
| author | John Keller <jpk@sgi.com> | 2007-05-10 22:42:44 -0700 |
|---|---|---|
| committer | Tony Luck <tony.luck@intel.com> | 2007-05-11 09:35:38 -0700 |
| commit | 25d61578daae697c4a0eb817f42a868af9824f82 (patch) | |
| tree | ec4ac10132f0b12a822dba6a53d05bab78ec3760 /kernel/irq | |
| parent | 3e3d32770204ea24cf71919a90d9ccfc2bd407dd (diff) | |
[IA64] SN: validate smp_affinity mask on intr redirect
On SN, only allow one bit to be set in the smp_affinty mask when
redirecting an interrupt. Currently setting multiple bits is allowed, but
only the first bit is used in determining the CPU to redirect to. This has
caused confusion among some customers.
[akpm@linux-foundation.org: fixes]
Signed-off-by: John Keller <jpk@sgi.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Tony Luck <tony.luck@intel.com>
Diffstat (limited to 'kernel/irq')
| -rw-r--r-- | kernel/irq/proc.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/kernel/irq/proc.c b/kernel/irq/proc.c index ddde0ef9ccd..b4f1674fca7 100644 --- a/kernel/irq/proc.c +++ b/kernel/irq/proc.c @@ -27,6 +27,10 @@ static int irq_affinity_read_proc(char *page, char **start, off_t off, return len; } +#ifndef is_affinity_mask_valid +#define is_affinity_mask_valid(val) 1 +#endif + int no_irq_affinity; static int irq_affinity_write_proc(struct file *file, const char __user *buffer, unsigned long count, void *data) @@ -42,6 +46,9 @@ static int irq_affinity_write_proc(struct file *file, const char __user *buffer, if (err) return err; + if (!is_affinity_mask_valid(new_value)) + return -EINVAL; + /* * Do not allow disabling IRQs completely - it's a too easy * way to make the system unusable accidentally :-) At least |