diff options
| author | RongQing.Li <roy.qing.li@gmail.com> | 2011-11-30 23:43:07 -0500 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2011-11-30 23:43:07 -0500 |
| commit | 8f891489866ec62a87494eff3ed17c88152c32d4 (patch) | |
| tree | a3baca724faed04898f72e3e512f76892a1b05ce /net | |
| parent | ea6a5d3b97b768561db6358f15e4c84ced0f4f7e (diff) | |
net/core: fix rollback handler in register_netdevice_notifier
Within nested statements, the break statement terminates only the
do, for, switch, or while statement that immediately encloses it,
So replace the break with goto.
Signed-off-by: RongQing.Li <roy.qing.li@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/core/dev.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/core/dev.c b/net/core/dev.c index 1482eea0bbf..5a13edfc9f7 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -1396,7 +1396,7 @@ rollback: for_each_net(net) { for_each_netdev(net, dev) { if (dev == last) - break; + goto outroll; if (dev->flags & IFF_UP) { nb->notifier_call(nb, NETDEV_GOING_DOWN, dev); @@ -1407,6 +1407,7 @@ rollback: } } +outroll: raw_notifier_chain_unregister(&netdev_chain, nb); goto unlock; } |