summaryrefslogtreecommitdiff
path: root/net
diff options
context:
space:
mode:
authorJP Abgrall <jpa@google.com>2011-10-09 02:28:12 +0100
committerAndy Green <andy.green@linaro.org>2011-10-09 02:28:12 +0100
commita424c312182409ffdf5938cd0f318470e20bf8d7 (patch)
tree84df4c1b6d9450b62069bf070cc1812954f5a996 /net
parent0deb5fab62d5017853c7bbbe3d5bdc11aacd0b3c (diff)
netfilter: qtaguid: fix bad-arg handling when tagging socket
When processing args passed to the procfs ctrl, if the tag was invalid it would exit without releasing the spin_lock... Bye bye scheduling. Signed-off-by: JP Abgrall <jpa@google.com> Change-Id: Ic1480ae9d37bba687586094cf6d0274db9c5b28a
Diffstat (limited to 'net')
-rw-r--r--net/netfilter/xt_qtaguid.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/netfilter/xt_qtaguid.c b/net/netfilter/xt_qtaguid.c
index 3b5ab3ff061..3cacec07fbf 100644
--- a/net/netfilter/xt_qtaguid.c
+++ b/net/netfilter/xt_qtaguid.c
@@ -1065,7 +1065,7 @@ static int qtaguid_ctrl_parse(const char *input, int count)
goto ok;
err_unlock:
- if (!sock_tag_entry)
+ if (sock_tag_entry)
spin_unlock_irqrestore(&sock_tag_list_lock, flags);
err:
ok: