From 48ca68e93ce9a50f9e43d3f82668b02d48080a94 Mon Sep 17 00:00:00 2001 From: Per-Daniel Olsson Date: Tue, 6 Mar 2012 09:57:19 +0100 Subject: misc: compdev: Correction for overlay crash The compdev had a flaw which did not check return values while probing some UIBs. This has now been corrected. ST-Ericsson Linux next: NA ST-Ericsson ID: 419934 ST-Ericsson FOSS-OUT ID: Trivial Change-Id: I2b203e02ef8b5650d0c27247ac81cf2d0c20fbae Signed-off-by: Per-Daniel Olsson Reviewed-on: http://gerrit.lud.stericsson.com/gerrit/51532 Reviewed-by: Jonas ABERG Reviewed-by: QATOOLS Reviewed-by: Robert FEKETE --- drivers/misc/compdev/compdev.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'drivers/misc/compdev/compdev.c') diff --git a/drivers/misc/compdev/compdev.c b/drivers/misc/compdev/compdev.c index e0c34879f65..d929a02c565 100644 --- a/drivers/misc/compdev/compdev.c +++ b/drivers/misc/compdev/compdev.c @@ -1120,8 +1120,10 @@ int compdev_create(struct mcde_display_device *ddev, ret = -ENOMEM; goto fail_create_ovly; } - mcde_dss_enable_overlay(cd->dss_ctx.ovly[i]); - disable_overlay(cd->dss_ctx.ovly[i]); + if (mcde_dss_enable_overlay(cd->dss_ctx.ovly[i])) + goto fail_create_ovly; + if (disable_overlay(cd->dss_ctx.ovly[i])) + goto fail_create_ovly; } mcde_dss_get_native_resolution(ddev, &cd->dss_ctx.phy_size.width, -- cgit v1.2.3