From 3028474cb469ff5352bbc7cc685eee46ab8e888b Mon Sep 17 00:00:00 2001 From: Aaro Koskinen Date: Sun, 11 Sep 2011 00:29:53 +0300 Subject: staging: xgifb: properly delete MTRR region MTRR region should be deleted on probe failure and driver removal. Signed-off-by: Aaro Koskinen Signed-off-by: Greg Kroah-Hartman --- drivers/staging/xgifb/XGI_main_26.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) (limited to 'drivers/staging/xgifb/XGI_main_26.c') diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c index db9d27b04ce..e018b9a43bc 100644 --- a/drivers/staging/xgifb/XGI_main_26.c +++ b/drivers/staging/xgifb/XGI_main_26.c @@ -2424,13 +2424,19 @@ static int __devinit xgifb_probe(struct pci_dev *pdev, if (register_framebuffer(fb_info) < 0) { ret = -EINVAL; - goto error_1; + goto error_mtrr; } dumpVGAReg(); return 0; +error_mtrr: +#ifdef CONFIG_MTRR + if (xgi_video_info.mtrr >= 0) + mtrr_del(xgi_video_info.mtrr, xgi_video_info.video_base, + xgi_video_info.video_size); +#endif /* CONFIG_MTRR */ error_1: iounmap(xgi_video_info.mmio_vbase); iounmap(xgi_video_info.video_vbase); @@ -2451,6 +2457,11 @@ error: static void __devexit xgifb_remove(struct pci_dev *pdev) { unregister_framebuffer(fb_info); +#ifdef CONFIG_MTRR + if (xgi_video_info.mtrr >= 0) + mtrr_del(xgi_video_info.mtrr, xgi_video_info.video_base, + xgi_video_info.video_size); +#endif /* CONFIG_MTRR */ iounmap(xgi_video_info.mmio_vbase); iounmap(xgi_video_info.video_vbase); release_mem_region(xgi_video_info.mmio_base, xgi_video_info.mmio_size); -- cgit v1.2.3