diff options
author | Tormod Volden <debian.tormod@gmail.com> | 2011-05-30 19:45:43 +0000 |
---|---|---|
committer | Dave Airlie <airlied@redhat.com> | 2011-06-14 11:09:54 +1000 |
commit | 66aa6962ff520804f9874e57ea97995153f499d8 (patch) | |
tree | 7b9920427103a3889e1c7d85d032a26841e29cb1 /drivers/gpu/drm/radeon/r100_track.h | |
parent | b65552f06ca866f587a0a50d1f4dbdd3a00ec532 (diff) |
drm: Compare only lower 32 bits of framebuffer map offsets
Drivers using multiple framebuffers got broken by commit
41c2e75e60200a860a74b7c84a6375c105e7437f which ignored the framebuffer
(or register) map offset when looking for existing maps. The rationale
was that the kernel-userspace ABI is fixed at a 32-bit offset, so the
real offsets could not always be handed over for comparison.
Instead of ignoring the offset we will compare the lower 32 bit. Drivers
using multiple framebuffers should just make sure that the lower 32 bit
are different. The existing drivers in question are practically limited
to 32-bit systems so that should be fine for them.
It is assumed that current drivers always specify a correct framebuffer
map offset, even if this offset was ignored since above commit. So this
patch should not change anything for drivers using only one framebuffer.
Drivers needing multiple framebuffers with 64-bit map offsets will need
to cook up something, for instance keeping an ID in the lower bit which
is to be aligned away when it comes to using the offset.
All of above applies to _DRM_REGISTERS as well.
Signed-off-by: Tormod Volden <debian.tormod@gmail.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Diffstat (limited to 'drivers/gpu/drm/radeon/r100_track.h')
0 files changed, 0 insertions, 0 deletions