diff options
| author | Nick Kralevich <nnk@google.com> | 2010-11-05 11:47:12 -0700 |
|---|---|---|
| committer | Ulf Hansson <ulf.hansson@stericsson.com> | 2011-09-19 15:56:13 +0200 |
| commit | fdee64c0a672a4720fc4067a639db0ae73072358 (patch) | |
| tree | 64d038175d1ae50d297e277d29d64b0d068b9898 /drivers | |
| parent | 38130f90d12f29720672cc4775326d7587410d39 (diff) | |
staging: binder: Fix use of uninitialized variable.
Under an extremely rare condition, the variable return_error may
not be set. This patch initializes the value to a known "bad"
value, and checks before return to ensure return_error has been
set.
Signed-off-by: Nick Kralevich <nnk@google.com>
Change-Id: Id768ac28e6ba9c80ff15696d55034998a94ab81d
Reviewed-on: http://gerrit.lud.stericsson.com/gerrit/19499
Tested-by: Piotr TOMASZEWSKI <piotr.tomaszewski@stericsson.com>
Reviewed-by: Jonas ABERG <jonas.aberg@stericsson.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/staging/android/binder.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c index 3ca4d7d0bc8..426bb62e712 100644 --- a/drivers/staging/android/binder.c +++ b/drivers/staging/android/binder.c @@ -1610,6 +1610,7 @@ static void binder_transaction(struct binder_proc *proc, proc->pid, thread->pid, fp->binder, node->debug_id, fp->cookie, node->cookie); + return_error = BR_FAILED_REPLY; goto err_binder_get_ref_for_node_failed; } ref = binder_get_ref_for_node(target_proc, node); |