diff options
author | Thomas De Schampheleire <patrickdepinguin@gmail.com> | 2013-12-20 22:31:30 +0100 |
---|---|---|
committer | Thomas Petazzoni <thomas.petazzoni@free-electrons.com> | 2013-12-25 12:21:39 +0100 |
commit | 35eaed8d07bdc73a83990bc306fcdb08b2e70eaf (patch) | |
tree | fe38a982159d30eeadbc0a30462da1676bdd11b0 /package/libarchive | |
parent | 142a81d60533ef179300c44fd29aaefbfae62d3a (diff) |
Config.in files: use if/endif instead of 'depends on' for main symbol
In the Config.in file of package foo, it often happens that there are other
symbols besides BR2_PACKAGE_FOO. Typically, these symbols only make sense
when foo itself is enabled. There are two ways to express this: with
depends on BR2_PACKAGE_FOO
in each extra symbol, or with
if BR2_PACKAGE_FOO
...
endif
around the entire set of extra symbols.
The if/endif approach avoids the repetition of 'depends on' statements on
multiple symbols, so this is clearly preferred. But even when there is only
one extra symbol, if/endif is a more logical choice:
- it is future-proof for when extra symbols are added
- it allows to have just one strategy instead of two (less confusion)
This patch modifies the Config.in files accordingly.
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Diffstat (limited to 'package/libarchive')
-rw-r--r-- | package/libarchive/Config.in | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/package/libarchive/Config.in b/package/libarchive/Config.in index d4fb73fd5..81b5936ce 100644 --- a/package/libarchive/Config.in +++ b/package/libarchive/Config.in @@ -1,3 +1,6 @@ +comment "libarchive needs a toolchain w/ wchar" + depends on !BR2_USE_WCHAR + config BR2_PACKAGE_LIBARCHIVE bool "libarchive" depends on BR2_USE_WCHAR @@ -7,20 +10,18 @@ config BR2_PACKAGE_LIBARCHIVE http://www.libarchive.org/ -comment "libarchive needs a toolchain w/ wchar" - depends on !BR2_USE_WCHAR +if BR2_PACKAGE_LIBARCHIVE config BR2_PACKAGE_LIBARCHIVE_BSDTAR bool "bsdtar" - depends on BR2_PACKAGE_LIBARCHIVE help The 'bsdtar' program is a full-featured 'tar' replacement built on libarchive. config BR2_PACKAGE_LIBARCHIVE_BSDCPIO bool "bsdcpio" - depends on BR2_PACKAGE_LIBARCHIVE help The 'bsdcpio' program is a different interface to essentially the same functionality as 'bsdtar'. +endif |