diff options
| author | Thomas De Schampheleire <patrickdepinguin@gmail.com> | 2013-12-20 22:31:30 +0100 |
|---|---|---|
| committer | Thomas Petazzoni <thomas.petazzoni@free-electrons.com> | 2013-12-25 12:21:39 +0100 |
| commit | 35eaed8d07bdc73a83990bc306fcdb08b2e70eaf (patch) | |
| tree | fe38a982159d30eeadbc0a30462da1676bdd11b0 /package/matchbox | |
| parent | 142a81d60533ef179300c44fd29aaefbfae62d3a (diff) | |
Config.in files: use if/endif instead of 'depends on' for main symbol
In the Config.in file of package foo, it often happens that there are other
symbols besides BR2_PACKAGE_FOO. Typically, these symbols only make sense
when foo itself is enabled. There are two ways to express this: with
depends on BR2_PACKAGE_FOO
in each extra symbol, or with
if BR2_PACKAGE_FOO
...
endif
around the entire set of extra symbols.
The if/endif approach avoids the repetition of 'depends on' statements on
multiple symbols, so this is clearly preferred. But even when there is only
one extra symbol, if/endif is a more logical choice:
- it is future-proof for when extra symbols are added
- it allows to have just one strategy instead of two (less confusion)
This patch modifies the Config.in files accordingly.
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Diffstat (limited to 'package/matchbox')
| -rw-r--r-- | package/matchbox/Config.in | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/package/matchbox/Config.in b/package/matchbox/Config.in index d89a1762e..67c971622 100644 --- a/package/matchbox/Config.in +++ b/package/matchbox/Config.in @@ -9,23 +9,23 @@ config BR2_PACKAGE_MATCHBOX help http://projects.o-hand.com/matchbox +if BR2_PACKAGE_MATCHBOX + config BR2_PACKAGE_MATCHBOX_PANEL bool "Matchbox Panel" - depends on BR2_PACKAGE_MATCHBOX help A flexible always present 'window bar' for holding application launchers. config BR2_PACKAGE_MATCHBOX_DESKTOP bool "Matchbox Desktop" - depends on BR2_PACKAGE_MATCHBOX select BR2_PACKAGE_ZLIB help A PDA style application launcher or 'item browser'. config BR2_PACKAGE_MATCHBOX_COMMON bool "Matchbox session common files" - depends on BR2_PACKAGE_MATCHBOX && BR2_PACKAGE_MATCHBOX_PANEL && BR2_PACKAGE_MATCHBOX_DESKTOP + depends on BR2_PACKAGE_MATCHBOX_PANEL && BR2_PACKAGE_MATCHBOX_DESKTOP help Common desktop folders and matchbox-session script. @@ -35,7 +35,8 @@ config BR2_PACKAGE_MATCHBOX_COMMON_PDA config BR2_PACKAGE_MATCHBOX_KEYBOARD bool "Matchbox Virtual Keyboard" - depends on BR2_PACKAGE_MATCHBOX select BR2_PACKAGE_XLIB_LIBXTST help Virtual Keyboard + +endif |