diff options
| author | Yann E. MORIN <yann.morin.1998@free.fr> | 2016-10-01 21:04:47 +0200 |
|---|---|---|
| committer | Peter Korsgaard <peter@korsgaard.com> | 2016-10-02 21:21:22 +0200 |
| commit | 0e2ee0e6e8076d233402766086aa4c6297c62cb9 (patch) | |
| tree | 54606279ea326bf1efb600484b37a84aee6bcfcf /package/snappy | |
| parent | bfaaab0e362d636e7fb749ae208523cc88f1e87f (diff) | |
package.snappy: fix static builds with threads
For some toolchains, libstdc++ uses pthread symbols:
.../lib/libstdc++.a(eh_alloc.o): In function `__gnu_cxx::__mutex::lock()':
eh_alloc.cc:(.text._ZN9__gnu_cxx7__mutex4lockEv[_ZN9__gnu_cxx7__mutex4lockEv]+0x2):
undefined reference to `pthread_mutex_lock'
and a lot of other pthread symbols...
However, when doing a static build, there is no way for the linker to know
what library to link in, so the build fails miserably if -pthread is not
specified at link time.
Fixes:
http://autobuild.buildroot.org/results/15e/15ecaa23f0116e8120b3d62e553c838f0303df35/
http://autobuild.buildroot.org/results/f0a/f0abe301816e39eb4ae26d3e8cd42d90901d5ac5/
[Peter: only perform workaround if toolchain has threads support, tweak comment]
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Diffstat (limited to 'package/snappy')
| -rw-r--r-- | package/snappy/snappy.mk | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/package/snappy/snappy.mk b/package/snappy/snappy.mk index b00dddf6c..6f89cf11c 100644 --- a/package/snappy/snappy.mk +++ b/package/snappy/snappy.mk @@ -16,4 +16,13 @@ SNAPPY_INSTALL_STAGING = YES # Disable tests SNAPPY_CONF_OPTS = --disable-gtest +# libsnappy links with libstdc++. Some libstdc++/arch variants use +# pthread symbols for internal locking if built with thead +# support. libstdc++ does not have a .pc file, and its .la file does +# not mention -pthread. So, static linkig to libstdc++ will fail if +# -pthread is not explicity linked to. Only do that for static builds. +ifeq ($(BR2_STATIC_LIBS)$(BR2_TOOLCHAIN_HAS_THREADS),yy) +SNAPPY_CONF_OPTS += LIBS=-pthread +endif + $(eval $(autotools-package)) |